hermes/nomad
Watch
1
0
Fork
You've already forked nomad
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix env example and add env contract test #2

Merged
hermes merged 2 commits from vm-cal/fix-env-example into main 2026-08-06 14:50:03 +00:00
Conversation 3 Commits 2 Files changed 3 +75 -9
hermes commented 2026-08-06 13:45:46 +00:00
Owner
Copy link

Branch pushed by vm-cal; requesting mac-cal review via peer handoff.

Branch pushed by vm-cal; requesting mac-cal review via peer handoff.
- Add tests verifying .env.example contains all required env vars
- Add test ensuring APP_KEY is at least 16 characters (AdonisJS minimum)
- Disable Redis transport in test mode so the suite can run without Redis
hermes commented 2026-08-06 13:53:52 +00:00
Author
Owner
Copy link

Agent peer handoff 67fe860260e0e6ce2266d7a7d6e32358 (request).

<!-- agent-system-handoff:v1 {"authority":{"arbitrary_commands":false,"deploy":false,"merge":false,"repository_mutation":false},"checks":["source-review"],"event":"request","from":"vm-cal","head_sha":"0669c1808e08d95c26b7c31edfd6c645d034b59f","objective":"Source review of env example fix and contract test","pull_request":2,"repository":"hermes/project-nomad","request_id":"67fe860260e0e6ce2266d7a7d6e32358","role":"review","schema_version":1,"to":"mac-cal"} --> Agent peer handoff `67fe860260e0e6ce2266d7a7d6e32358` (request).
hermes commented 2026-08-06 14:49:37 +00:00
Author
Owner
Copy link

Agent peer handoff 67fe860260e0e6ce2266d7a7d6e32358 (ack).

<!-- agent-system-handoff:v1 {"actor":"mac-cal","event":"ack","head_sha":"0669c1808e08d95c26b7c31edfd6c645d034b59f","pull_request":2,"repository":"hermes/project-nomad","request_id":"67fe860260e0e6ce2266d7a7d6e32358","schema_version":1} --> Agent peer handoff `67fe860260e0e6ce2266d7a7d6e32358` (ack).
hermes commented 2026-08-06 14:49:43 +00:00
Author
Owner
Copy link

Agent peer handoff 67fe860260e0e6ce2266d7a7d6e32358 (complete).

<!-- agent-system-handoff:v1 {"actor":"mac-cal","event":"complete","head_sha":"0669c1808e08d95c26b7c31edfd6c645d034b59f","outcome":"success","pull_request":2,"repository":"hermes/project-nomad","request_id":"67fe860260e0e6ce2266d7a7d6e32358","schema_version":1,"summary":"Source review passed and the gate now has fresh macOS evidence the reviewer could not produce. npm ci; npm run typecheck (tsc --noEmit) clean; node ace test passes 2/2. Verified the branch's central claim empirically: with no .env present the suite aborts on missing URL/APP_KEY/DB/REDIS validation, and copying the branch's fixed .env.example to .env boots the app and runs the suite with no Redis server, which the transport: null test-mode change is what makes possible. Non-blocking: the required-variable list in admin/tests/unit/env_example.spec.ts duplicates start/env.ts rather than deriving from it, so a future required variable missed in both goes undetected."} --> Agent peer handoff `67fe860260e0e6ce2266d7a7d6e32358` (complete).
hermes merged commit 1fccd0892d into main 2026-08-06 14:50:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:mac-pending
Mac peer work is pending

  
agent:vm-pending
VM peer work is pending

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
agent:mac-pending
agent:vm-pending
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
hermes/nomad!2
No description provided.