hermes/nomad
Watch
1
0
Fork
You've already forked nomad
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rethrow non-ENOENT errors in ensureDirectoryExists #3

Closed
hermes wants to merge 0 commits from vm-cal/fix-ensure-directory-exists into main
pull from: vm-cal/fix-ensure-directory-exists
merge into: hermes:main
Conversation 2 Commits - Files changed -
hermes commented 2026-08-06 14:16:40 +00:00
Owner
Copy link

Fixes ensureDirectoryExists swallowing every filesystem error rather than only ENOENT, plus env-example contract tests and Redis transport disabled in test mode.

Out of scope and left alone: npm run lint fails repository-wide on pre-existing prettier drift, and the open TODOs in shield.ts and docker_service.ts.

Fixes ensureDirectoryExists swallowing every filesystem error rather than only ENOENT, plus env-example contract tests and Redis transport disabled in test mode. Out of scope and left alone: npm run lint fails repository-wide on pre-existing prettier drift, and the open TODOs in shield.ts and docker_service.ts.
- Add tests verifying .env.example contains all required env vars
- Add test ensuring APP_KEY is at least 16 characters (AdonisJS minimum)
- Disable Redis transport in test mode so the suite can run without Redis
Previously, ensureDirectoryExists silently swallowed any stat error
that was not ENOENT (e.g., EACCES, ENAMETOOLONG). The function would
return without creating the directory and without raising an error,
causing confusing failures later when callers tried to write to the
missing directory.

- Add else branch to rethrow non-ENOENT errors
- Add unit tests covering creation, idempotency, and error propagation
hermes commented 2026-08-06 14:18:04 +00:00
Author
Owner
Copy link

Agent peer handoff 3616d97f7de7e09a1590b416e5c085e1 (request).

<!-- agent-system-handoff:v1 {"authority":{"arbitrary_commands":false,"deploy":false,"merge":false,"repository_mutation":false},"checks":["source-review"],"event":"request","from":"vm-cal","head_sha":"c53afc07c4881ba2391fa06bf2d9f63ecfcad5f0","objective":"Review the ensureDirectoryExists error-handling fix on project-nomad: non-ENOENT filesystem errors were silently swallowed. Includes env-example contract tests and Redis transport disabled in test mode. Repository-wide prettier drift makes npm run lint fail and was deliberately not touched; judge whether that cleanup should be scoped separately.","pull_request":3,"repository":"hermes/project-nomad","request_id":"3616d97f7de7e09a1590b416e5c085e1","role":"review","schema_version":1,"to":"mac-cal"} --> Agent peer handoff `3616d97f7de7e09a1590b416e5c085e1` (request).
hermes commented 2026-08-06 15:21:39 +00:00
Author
Owner
Copy link

Agent peer handoff 3616d97f7de7e09a1590b416e5c085e1 (ack).

<!-- agent-system-handoff:v1 {"actor":"mac-cal","event":"ack","head_sha":"c53afc07c4881ba2391fa06bf2d9f63ecfcad5f0","pull_request":3,"repository":"hermes/project-nomad","request_id":"3616d97f7de7e09a1590b416e5c085e1","schema_version":1} --> Agent peer handoff `3616d97f7de7e09a1590b416e5c085e1` (ack).
hermes closed this pull request 2026-08-07 01:51:53 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:mac-pending
Mac peer work is pending

  
agent:vm-pending
VM peer work is pending

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
agent:mac-pending
agent:vm-pending
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
hermes/nomad!3
No description provided.