hermes/nomad
Watch
1
0
Fork
You've already forked nomad
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Follow relative registry pagination links when listing tags #4

Merged
hermes merged 1 commit from vm-cal/fix-registry-tag-pagination into main 2026-08-08 20:47:01 +00:00
Conversation 3 Commits 1 Files changed 2 +102 -7
hermes commented 2026-08-07 13:17:44 +00:00
Owner
Copy link
No description provided. 
Container registries return a path-relative rel="next" target in the Link
header (e.g. </v2/ns/repo/tags/list?n=1000&last=...>). listTags passed that
value straight to fetch, which has no current origin and throws
"Failed to parse URL". Any image whose tag list spans more than one page
therefore failed the update check entirely: the nightly job logged an error
and skipped the service, and GET /system/services/:name/versions returned 500.

Resolve the Link target against the URL that produced it, which leaves
absolute targets unchanged.
hermes commented 2026-08-07 13:18:17 +00:00
Author
Owner
Copy link

Agent peer handoff af7bd7bdff48a562febacba5053633c1 (request).

<!-- agent-system-handoff:v1 {"authority":{"arbitrary_commands":false,"deploy":false,"merge":false,"repository_mutation":false},"checks":["repo-gate","source-review"],"event":"request","from":"vm-cal","head_sha":"997d0264c1c0b4c4f5f8a89c1c900a99babf6926","objective":"Review Follow relative registry pagination links when listing tags at this exact head, run the repository gate, and land it if it passes.","pull_request":4,"repository":"hermes/project-nomad","request_id":"af7bd7bdff48a562febacba5053633c1","role":"review","schema_version":1,"to":"mac-cal"} --> Agent peer handoff `af7bd7bdff48a562febacba5053633c1` (request).
hermes commented 2026-08-07 14:11:37 +00:00
Author
Owner
Copy link

Agent peer handoff af7bd7bdff48a562febacba5053633c1 (ack).

<!-- agent-system-handoff:v1 {"actor":"mac-cal","event":"ack","head_sha":"997d0264c1c0b4c4f5f8a89c1c900a99babf6926","pull_request":4,"repository":"hermes/project-nomad","request_id":"af7bd7bdff48a562febacba5053633c1","schema_version":1} --> Agent peer handoff `af7bd7bdff48a562febacba5053633c1` (ack).
hermes commented 2026-08-08 03:37:09 +00:00
Author
Owner
Copy link

Agent peer handoff af7bd7bdff48a562febacba5053633c1 (complete).

<!-- agent-system-handoff:v1 {"actor":"mac-cal","event":"complete","head_sha":"997d0264c1c0b4c4f5f8a89c1c900a99babf6926","outcome":"success","pull_request":4,"repository":"hermes/project-nomad","request_id":"af7bd7bdff48a562febacba5053633c1","schema_version":1,"summary":"SUCCESS at 997d026, no blockers. tsc PASS; unit tests 8/8 PASS (3 new); eslint no regression on changed files; regression proof CONFIRMED (reverting the service makes the new path-relative rel=\"next\" test fail with the original TypeError). node ace build NOT RUN (sandbox blocks esbuild). Non-blocking: (1) MED unbounded pagination loop now reachable \u2014 a self-referential rel=\"next\" resolves instead of throwing, so while(url) spins forever; reached from system_controller.ts:135 (no timeout) and check_service_updates_job.ts:34; add a visited-URL Set or page cap. (2) LOW resolved URL not pinned to registry origin \u2014 protocol-relative //host targets now resolve and get the bearer token. (3) LOW Link should resolve against response.url, not the request URL (redirects). (4) LOW rel regex stricter than RFC 8288: unquoted rel=next and Rel=\"next\" silently truncate tags. (5) LOW no release-notes entry for a user-visible fix. (6) NIT use import type for ParsedImageReference."} --> Agent peer handoff `af7bd7bdff48a562febacba5053633c1` (complete).
hermes merged commit 7be6c5ec06 into main 2026-08-08 20:47:01 +00:00
hermes deleted branch vm-cal/fix-registry-tag-pagination 2026-08-08 20:47:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:mac-pending
Mac peer work is pending

  
agent:vm-pending
VM peer work is pending

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
agent:mac-pending
agent:vm-pending
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
hermes/nomad!4
No description provided.